skills/reviewing-readability/SKILL.md
Code readability review. Use when: 可読性, 明確, 命名, 変数名, 関数名, ネスト, 関数設計, コメント, 複雑, Miller's Law, ミラーの法則, 認知負荷, AI-generated, 過剰設計. Do NOT use for security (reviewing-security), type errors (reviewing-type-safety), error handling (reviewing-silent-failures), or test design (reviewing-testability).
npx skillsauth add thkt/dotclaude reviewing-readabilityInstall this skill globally with one command. Works with Claude Code, Cursor, and Windsurf.
3 of 9 scanners reported clean
Some scanners were skipped, did not run, or reported a non-clean status. Review each row below.
Thresholds: see rules/development/THRESHOLDS.md.
| ID | Pattern | Fix |
| --- | ----------------------------- | -------------------------------- |
| RD1 | processData() (vague) | validateUserEmail() |
| RD1 | Misleading identifiers | Names reveal intent |
| RD2 | Nesting > 3 levels | Guard clauses, extract functions |
| RD2 | Function > 30 lines | Decompose |
| RD3 | Comment: // increment i | Delete (self-evident) |
| RD3 | Comment: // TODO: fix later | Create issue or fix now |
| RD4 | Interface for single impl | Remove until 2nd impl |
| RD4 | Class for stateless logic | Pure function |
| RD5 | > 5 function parameters | Config object or decompose |
| Topic | File |
| --------------- | ---------------------------------------------------- |
| Control Flow | ${CLAUDE_SKILL_DIR}/references/control-flow.md |
| Comments | ${CLAUDE_SKILL_DIR}/references/comments-clarity.md |
| AI Antipatterns | ${CLAUDE_SKILL_DIR}/references/ai-antipatterns.md |
| Naming | ${CLAUDE_SKILL_DIR}/references/naming.md |
tools
Delegate implementation to codex (coder) via the herdr-agentchat plugin and drive a two-pane conversation to completion.
development
Extract recurring patterns from past closed PRs/issues and the research findings in workspace/research/, verify them against the latest code, and propose them to docs/wiki/ via PR.
development
Create Decision Records (DR) in MADR v4 format with auto-numbering.
development
Detect flaky tests by shaking them — repeated runs under varied order, parallelism, and seed — plus a static smell scan that flags latent flakiness in tests that currently pass. Classify each target as confirmed-flaky, latent-flaky, or stable and fix the root cause without weakening the test. Do NOT use to fix a confirmed single bug (use /fix) or for static-only code review (use /audit).