yaacov/update-forklift-version

Updating the Forklift Dependency

1. Fetch the Latest Version

GOFLAGS=-mod=mod GOPROXY=https://proxy.golang.org,direct \
  go get github.com/kubev2v/forklift@latest
go mod tidy
go mod vendor
go build ./...

Verify the build succeeds before proceeding.

2. Check ForkliftController Settings

Settings are defined in pkg/cmd/settings/types.go in two maps:

• SupportedSettings -- commonly configured settings
• ExtendedSettings -- advanced/less-common settings

Upstream Source of Truth

Fetch the Ansible defaults file (canonical defaults for all settings):

https://raw.githubusercontent.com/kubev2v/forklift/main/operator/roles/forkliftcontroller/defaults/main.yml

What to Compare

For every setting in our maps, compare against the upstream file:

| Check | Action | |-------|--------| | Default value mismatch | Update Default field in our definition | | Setting removed upstream | Search vendored code (vendor/github.com/kubev2v/forklift/) to confirm removal, then delete from our map | | New setting upstream | Add to SupportedSettings (user-facing) or ExtendedSettings (advanced) with correct type, default, description, and category | | New category needed | Add to SettingCategory constants and CategoryOrder slice in types.go |

Verification

Run go test ./pkg/cmd/settings/... -- the test suite checks:

• Name/key consistency
• No overlap between Supported and Extended
• All categories in CategoryOrder are covered
• Sorting within categories

3. Check Plan CRD Changes

The Plan CRD types live in the vendor at:

vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan.go     # PlanSpec, PlanStatus
vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan/vm.go  # plan.VM struct

Files to Update for New PlanSpec Fields

| File | What to update | |------|---------------| | cmd/create/plan.go | Add CLI flag, wire into planSpec | | cmd/patch/plan.go | Add CLI flag, wire into PatchPlanOptions | | pkg/cmd/patch/plan/plan.go | Handle new field in patch builder | | pkg/cmd/describe/plan/describe.go | Display new field in buildSpecSection | | MCP help generator | If the flag should be visible to AI assistants |

Files to Update for New VM Struct Fields

| File | What to update | |------|---------------| | cmd/patch/plan.go (NewPlanVMCmd) | Add CLI flag for VM-level field | | pkg/cmd/patch/plan/plan.go (PatchPlanVM) | Handle new VM field in patch | | pkg/cmd/describe/plan/describe.go (buildVMsSection) | Display new VM field |

Boolean Fields with kubebuilder Defaults

When a PlanSpec bool has +kubebuilder:default:=true, the API server auto-sets it. If the CLI needs to explicitly set it to false, a post-create patch is required (see existing pattern in pkg/cmd/create/plan/plan.go for MigrateSharedDisks, PreserveStaticIPs, UseCompatibilityMode, etc.).

Pointer Bool Fields (*bool)

Fields like InstallLegacyDrivers and EnableNestedVirtualization use *bool so they can be nil (auto-detect), true, or false. The CLI flag should be a StringVar accepting "true", "false", or "auto" (= nil/auto-detect). Use "auto" as the default in create commands. In patch commands use "" as the default (meaning "don't change") and add a Changed flag so that --flag auto can explicitly clear the field back to nil.

4. Check Other CRD Changes

Also review for changes in:

vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/provider.go  # ProviderSpec, ProviderType
vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/mapping.go   # NetworkPair, StoragePair, DestinationNetwork
vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/host.go
vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/hook.go

Key things to watch:

• New ProviderType constants (new source provider types)
• New StorageVendorProduct enum values (update completion lists)
• New DestinationNetwork.Type enum values (update network pair parsing)
• New MigrationType constants
• Changes to ProviderSpec.Settings keys

5. Run Full Test Suite

go test ./... -count=1
go build ./...

Quick Diff Checklist

After vendoring the new version, a fast way to spot changes:

# See what files changed in the vendored forklift package
git diff --name-only -- vendor/github.com/kubev2v/forklift/

# Detailed diff of CRD types
git diff -- vendor/github.com/kubev2v/forklift/pkg/apis/