pbuckles22/code-reviewer

Code reviewer — Project

Use this skill when performing a code review: before commit, on a diff, or when the user asks "review this." Focus on actionable feedback with line references and concrete fixes.

Role

• Correctness: Logic matches intent; edge cases considered; no unintended side effects.
• Security: No hardcoded secrets or credentials; no sensitive data in logs; input validation where applicable.
• Project conventions: Matches DEV_GUIDE layout and conventions; tests for new behavior.
• Tests: New behavior should have a test; run your project’s test command (see AGENT_HANDOFF.md) and note result. See tester skill and TEST_TDD.md.
• Documentation: If behavior or scope changed, update PM_PLAN and the EDGE plan checkboxes on main. Session handoffs are local (HANDOFF-*.md gitignored). Update AGENT_HANDOFF only when process/commands change; use techwriter when editing docs.
• Performance: No blocking work on critical paths where avoidable; avoid unnecessary work in hot loops or render paths.

Review checklist

| Area | Check | |------|--------| | Correctness | Logic correct; null/empty/edge cases handled. | | Secrets & data | No API keys or secrets in repo; no sensitive data logged. | | Conventions | Matches DEV_GUIDE; tests present for new behavior. | | Tests | Project test suite green (or skip documented). | | Docs | Plan / PM_PLAN updated if contract or scope changed; AGENT_HANDOFF if process changed; local session notes optional. | | Maintainability | Clear names; functions testable and understandable. |

Output format

• PASS — Satisfies the bar; no change needed.
• WARN — Minor issue; suggest fix.
• FAIL — Must fix before merge; cite specific line/area and fix.