future3ooo/cockpit-code-quality-gate

Cockpit Code Quality Gate

When to use

• Any task that intends to return outcome="done" for USER_REQUEST, ORCHESTRATOR_UPDATE, or EXECUTE.

Hard rules

1) Code volume

• Every line must earn its place.
• Prefer deletion over wrappers.
• No one-off helper/wrapper functions for single-use operations.
• No premature abstraction; small direct duplication is acceptable until it is clearly shared.
• Remove unused code fully; do not leave _unused placeholders or "removed" comments.

2) No duplication

• Before adding a new function, check for an existing path that already solves the requirement.
• If two code paths perform the same operation, consolidate into one shared path.
• Keep shared operations centralized instead of spreading equivalent variants across modules.

3) Shortest path

• Keep data flow direct; remove unnecessary hops/transforms/retries.
• Every network, file, and process step must be justified.
• If a step can be removed without behavior loss, remove it.

4) Cleanup (zero tolerance)

• Cleanup must exist at startup, pre-task, and post-task.
• Temporary artifacts (local/remote) must not remain after completion.
• Partial failure/interruption cleanup paths are mandatory.
• If cleanup cannot be completed safely, return blocked/needs_review with exact blocker.

5) Anticipate consequences

• Trace downstream consumers before changing limits/contracts/data-shapes.
• Update all impacted consumers in the same change.
• Verify full flow before closure; no partial/local-only closure for cross-boundary changes.

6) Simplicity

• Choose minimal correct implementations over verbose patterns.
• Avoid redundant comments, noisy scaffolding, and unnecessary type/abstraction overhead.
• Production quality means small, correct, and maintainable.

Banned fake-green patterns

• No blanket suppressions to silence tooling (eslint-disable, @ts-ignore, # type: ignore) unless explicitly justified and scoped.
• No exit-code swallowing in verification paths (|| true and equivalent).
• No broad empty catch/pass patterns that hide failure (catch {}, .catch(() => {}), except: pass).
• No env-based or implicit code-quality gate bypasses. Audited branch-diff exceptions are allowed only via docs/agentic/CODE_QUALITY_EXCEPTIONS.json, must stay PR-scoped + standalone-only, and may waive only the exact named checks recorded in the registry/decision entry.

Required evidence before done

• Run: node scripts/code-quality-gate.mjs check --task-kind <KIND>
• Runtime enforcement is authoritative and fail-closed.
• This skill is closure-only and modularity-only. Pre-edit planning doctrine belongs in the writer preflight path, not here.
• When runtime scripts change, include matching scripts/__tests__ updates in the same delta.
• Skill-file edits must pass skill validators (validate-codex-skills and skills-format --check) when available.
• Modularity rules are hard blockers:
  • existing non-test source file with baseline physical line count > 500 enters no-growth mode and must end smaller if touched
  • new non-test source file with final physical line count > 300 fails
  • existing non-test source file with net growth > 120 fails unless exact same parent directory shrink offsets it
  • protected hosts must end smaller and pair with extraction under scripts/lib/
  • repo-path matcher changes in scripts/lib/code-quality-modularity*.mjs are modularity-policy changes; keep gate tests and this skill in sync, and preserve **/ as zero-or-more directories, not one-or-more
• Provide minimal closure evidence only:
  • include qualityReview.summary as one line,
  • include qualityReview.legacyDebtWarnings=<count> (non-blocking; must be acknowledged),
  • include all qualityReview.hardRuleChecks keys with one concise line each: codeVolume,noDuplication,shortestPath,cleanup,anticipateConsequences,simplicity,
  • do not paste full gate reports/logs in task notes.

Composition rule

• Keep this skill as a gate contract.
• Keep language-specific rules in dedicated skills (TS/Python policy skills).
• Keep learning lifecycle in SkillOps skills.

Learned heuristics (SkillOps)

<!-- SKILLOPS:LEARNED:BEGIN --> <!-- SKILLOPS:LEARNED:END -->