edercnj/x-review-developer

Skill: x-review-developer — Developer Language Review Orchestrator

Purpose

Orchestrate developer review for backend scope by detecting active Java signals in the project and dispatching to x-internal-review-developer-java.

Analogous to x-review-specialist for domain specialists, this skill handles the developer dimension for Java backend: language idioms, framework conventions, language-specific anti-patterns, and developer best practices.

Triggers

• /x-review-developer — review current branch (auto-detect language)
• /x-review-developer STORY-ID — review specific story
• /x-review-developer --lang java — force Java review

Parameters

| Parameter | Required | Description | |-----------|----------|-------------| | STORY-ID | No | Story to review (pattern: story-XXXX-YYYY). Defaults to current-branch detection. | | --lang <list> | No | Override language detection with explicit comma-separated list. | | --interactive | No | Enable interactive mode (Rule 20). |

Output Contract

| Artifact | Path | |----------|------| | Per-language developer report | .aikittools/features/feature-XXXX/reviews/review-developer-{lang}-story-XXXX-YYYY.md |

Language Detection → Skill Mapping

| Language | Detection Evidence | Internal Skill | |----------|--------------------|----------------| | java | *.java files, pom.xml, Gradle with Java config | x-internal-review-developer-java |

Canonical Technology Selection

Skill(skill: "x-internal-evaluate-tech-context",
      args: "--phase review --capabilities java")

Skill(skill: "x-internal-select-context-packs",
      args: "--phase review --capabilities java")

Workflow Overview

Phase 0: DETECT   → identify story/branch + detect active languages
Phase 1: DISPATCH → invoke x-internal-review-developer-java
Phase 2: COLLECT  → gather Java report and console summary

Phases 0–2

• Phase 0 — Detect: extract story ID; run git diff main --stat; invoke x-internal-evaluate-tech-context to detect Java signals; apply --lang override if provided; if Java is not detected, log warning and exit gracefully (no abort).

  Technology Versions loading (primary source for versioned pattern selection):

  ARCH_FILE=$(ls .aikittools/features/feature-XXXX/plans/arch-story-XXXX-YYYY.md 2>/dev/null | head -1)
  grep -A 30 "## Technology Versions" "$ARCH_FILE" 2>/dev/null | head -40
  

  Store the resulting version map as TECH_VERSIONS. x-internal-review-developer-java uses this map to select the correct versioned pattern directory. Fallback: techProfile.versions from x-internal-evaluate-tech-context.

• Phase 1 — Dispatch: emit a SINGLE assistant message with TaskCreate + Skill(x-internal-review-developer-java); pass story context and TECH_VERSIONS; then TaskUpdate; wait for completion.

• Phase 2 — Collect: aggregate Java report; display console summary with Java STATUS (GO/GO-WITH-RESERVATIONS/NO-GO/Skipped); confirm the report has been saved to the correct path.

Console Summary Format

=== Developer Review Summary ===
Languages detected: java
─────────────────────────────────────────────────────────────
Java           SCORE: 36/45  80%  STATUS: GO                  → review-developer-java-story-XXXX-YYYY.md
─────────────────────────────────────────────────────────────
Overall: GO

Error Envelope

Convenções de erro/degradação transversais a review/audit (empty input, RULE-012 template fallback, falha de specialist, build/test override, idempotência) vivem em _shared/error-handling-review.md. As linhas abaixo são específicas desta skill.

| Scenario | Action | |----------|--------| | No language detected | Log WARNING, exit gracefully (non-fatal — x-review-pr continues) | | Language detected but --lang override provided | Use --lang list; ignore auto-detection | | Internal skill returns invalid output | Mark language as FAILED, score 0, continue | | No changes found for a detected language | Skip that language review, log INFO |

Integration Notes

| Skill | Relationship | Context | |-------|-------------|---------| | x-review-pr | called-by | x-review-pr Phase 2 invokes this skill | | x-review-specialist | sibling | Runs in parallel with this skill (Phase 1+2 of x-review-pr) | | x-review-tech-lead | followed-by | Tech Lead reads all developer reports produced here | | x-internal-review-developer-java | calls | Conditional: java detected | | x-internal-evaluate-tech-context | calls | Language auto-detection |