cuozg/unity-review-local

Unity Local Code Review

Review locally changed Unity C# files by adding inline // ── REVIEW comments.

1. Determine Review Scope

| User Request | Diff Command | Scope | | ----------------------------- | --------------------- | -------------------------------- | | "review my changes" (default) | git diff HEAD | All unstaged + staged changes | | "review staged changes" | git diff --cached | Only staged changes | | "review this file" + path | Read full file | Specific file(s), no diff needed | | "review since last commit" | git diff HEAD~1 | Changes in last commit |

If no changes found: Check git status. If working tree is clean, inform user. If scope is big: Ask the user which specific criteria they need to review.

2. Group Files by Type

From the diff output, group files by type (.cs, .prefab, .unity, .mat, .shader). Ignore .meta.

3. Fast and Focused Reading

Review diff hunks first. Only fetch surrounding methods/assets when needed. Do not read the full file by default.

4. Spawn Parallel Review Subagents

See unity-standards/references/review/parallel-review-criteria.md for the strict schema and subagent prompt.

• When reviewing criteria with a big scope, split the work and spawn multiple subagents.

5. Aggregate and Validate

1. Merge findings from all subagents into a single list.
2. Deduplicate by (path, line) — keep highest severity.
3. Sort by file path → line number.
4. Validate high-confidence findings:
   • Dead code claims — verify nothing references the symbol.
   • Missing unsubscription — verify the subscription actually exists.

6. Annotate Source Files

Insert // ── REVIEW comments directly above the problem line using the finding's title, impact, evidence, and fix_direction:

// ── REVIEW {icon} {LABEL} #{category}
// What: {title}
// Why: {impact} - {evidence}
// Fix: {fix_direction}

• Labels: 🔴 CRITICAL, 🟠 HIGH, 🟡 MEDIUM, 🔵 LOW, ⚪ STYLE
• Categories: null-safety lifecycle state concurrency allocation serialization event-leak logic security architecture

7. Apply Safe Fixes

Apply only trivial, safe, single-line fixes:

• Add null check: if (component != null)
• Cache GetComponent: move to Awake/Start field
• Add missing unsubscription in OnDisable/OnDestroy
• Add CompareTag replacement for tag ==
• Add [FormerlySerializedAs] for renamed fields

Never apply multi-line refactors, architectural changes, or behavioral modifications. Leave those as // ── REVIEW comments. Never commit review changes — leave for inspection.