agents/skills/pre-pr/SKILL.md
Run complete validation before creating a PR - security, tests, breaking changes, and generate PR description
npx skillsauth add carterdea/dots pre-prInstall this skill globally with one command. Works with Claude Code, Cursor, and Windsurf.
3 of 9 scanners reported clean
Some scanners were skipped, did not run, or reported a non-clean status. Review each row below.
Complete validation pipeline to run before creating a pull request.
PHASE 1: SECURITY & COMPLIANCE (Blocking)
PHASE 2: QUALITY (Blocking) 4. Test Coverage Gate -> Tests exist 5. Breaking Change Check -> API compatibility 6. Performance Analyzer -> N+1, blocking I/O
PHASE 3: POLISH (Non-blocking) 7. Type Modernization -> Modern Python types 8. Code Simplification -> Refactoring suggestions
PHASE 4: OUTPUT 9. Run Tests -> pytest / vitest 10. Run Linters -> ruff, basedpyright, biome 11. Generate PR Desc -> Ready-to-paste description
git branch --show-current git log main..HEAD --oneline git diff --name-only main...HEAD
Based on changed files, run appropriate checks:
.py files -> Python pipeline.ts files -> TypeScript backend checks.tsx files -> Frontend checksSTOP if CRITICAL or HIGH issues found.
any, let, proper importsWARN if breaking changes detected.
cd chat-services && uv run pytest -x -v
cd backend && bun run test
cd frontend && bun run test
cd chat-services && uv run ruff check . && uv run basedpyright
bun run lint && bun run typecheck
--quick - Fast mode, critical checks only--no-tests - Skip test execution--python-only - Only check Python code--typescript-only - Only check TypeScript codedevelopment
Add net-new product, workflow, platform, or developer-experience features as small vertical slices. Use this skill whenever the user asks to build a new feature, add a new page/route/API/workflow/job/eval/operator path, enrich an existing feature with a new user-visible capability, or plan feature architecture before coding. This skill maps the files to change or create, defines the authoritative contract, specifies tests, and gives a QA plan before treating the feature as done.
development
Verify a developer's finished Trello ticket on a non-Shopify web app and render a verdict. Dogfood the posted preview (desktop + mobile) against the card's acceptance criteria, then PASS it (approve the PR, move to Ready for Release) or FAIL it (request changes, attach repro, reassign the dev, move to Development). Read-only: never implements, commits, or opens a PR. Use when asked to 'QA this card', 'test before release', or 'sign off on this ticket'. Shopify themes use shopify-trello-qa; building a ticket uses trello-delivery.
development
Verify a developer's finished Shopify theme ticket and render a verdict. Dogfood the posted preview theme and Customizer (desktop + mobile) against the card's acceptance criteria and Figma, then PASS it (approve the PR, move to Ready for Release) or FAIL it (request changes, attach repro, reassign the dev, move to Development). Read-only: never implements, commits, deploys, or opens a PR. Use when asked to 'QA this Shopify card', 'verify the Ready for Testing card', or 'sign off on this theme ticket'. Non-Shopify apps use trello-qa; building a ticket uses shopify-trello-delivery.
development
Survey any codebase as a senior advisor and produce prioritized, self-contained implementation plans for OTHER models/agents to execute. Strictly read-only on source code — never implements, fixes, or refactors anything itself. Use when asked to audit a codebase, find improvement opportunities (bugs, security, performance, test coverage, tech debt, migrations, DX), suggest features or where to take the project next (roadmap, product direction), or generate handoff plans for another agent to implement.