BubbleBuffer/requesting-code-review

Requesting Code Review

Dispatch superpawers-reviewer to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history. This keeps the reviewer focused on the work product, not your thought process, and preserves your own context for continued work.

Core principle: Review early, review often.

When to Request Review

Inside subagent-driven development: Spec compliance and code quality reviews are dispatched automatically between tasks. Use this skill within that flow only for additional milestone-level reviews.

Ad-hoc and standalone reviews:

• After completing major feature
• Before merge to main
• When stuck (fresh perspective)
• Before refactoring (baseline check)
• After fixing complex bug

How to Request

1. Get git SHAs:

BASE_SHA=$(git rev-parse HEAD~1)  # or origin/main
HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code-reviewer subagent:

Use subagent_type="superpawers-reviewer" with template at ../subagent-driven-development/reviewer.template.md

Pass {{full_review}} as the focus area for a complete review covering spec compliance, code quality, and production readiness.

3. Act on feedback:

• Fix Critical issues immediately
• Fix Important issues before proceeding
• Note Minor issues for later
• Push back if reviewer is wrong (with reasoning)

Example

[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch reviewer subagent]:
  Task(
    "Review verification and repair functions",
    subagent_type="superpawers-reviewer",
    prompt="<reviewer.template.md with {{full_review}}> + WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index + PLAN_OR_REQUIREMENTS: Task 2 from .superpawers/plans/deployment-plan.md + BASE_SHA: a7981ec + HEAD_SHA: 3df7661 + DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types"
  )

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]

Integration with Workflows

Inside subagent-driven-development:

• Spec compliance and code quality reviews are already dispatched automatically between tasks. Use this skill only when you need an additional review (for example, a full-implementation review at a milestone).

Ad-hoc or milestone review:

• Before merge or PR creation
• After completing a major feature outside the subagent flow
• When stuck and a fresh perspective would help

After the review returns:

• Use receiving-code-review to evaluate and apply the feedback. That skill governs how to verify, push back, and implement review items.

Red Flags

Never:

• Skip review because "it's simple"
• Ignore Critical issues
• Proceed with unfixed Important issues
• Argue with valid technical feedback

If reviewer wrong:

• Push back with technical reasoning
• Show code/tests that prove it works
• Request clarification

See agent system prompt at: agents/superpawers-reviewer.system.md See consolidated reviewer template at: ../subagent-driven-development/reviewer.template.md